[bug-1737]: Check if CSM is Authorization Proxy Server by checking module name #893
+172
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atye
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
sharmilarama and
shanmydell
as code owners
atye
force-pushed
the
usr/atye/bug-1737-authorization-name
branch
from
399092a to
b0d1fc3
Compare
atye
requested review from
AkshaySainiDell,
ChristianAtDell,
EvgenyUglov,
falfaroc and
rishabhatdell
as code owners
atye
force-pushed
the
usr/atye/bug-1737-authorization-name
branch
from
c496393 to
c13199e
Compare
donatwork
previously approved these changes
Feb 13, 2025
| if instance.GetName() != "" && instance.GetName() != string(csmv1.Authorization) && instance.GetName() != string(csmv1.ApplicationMobility) { | ||
| if instance.GetName() != "" && !isAuthorizationProxyServer(instance) && instance.GetName() != string(csmv1.ApplicationMobility) { |
There was a problem hiding this comment.
Can you explain this change? Does the authorization proxy server only exist for auth v1?
There was a problem hiding this comment.
instance.GetName() != string(csmv1.Authorization) checks if the Authorization CSM name is authorization. Assuming the user doesn't modify the default name in the sample, it'll work. If the user changes the CSM name, this check fails and reconciling will have issues.
A better check to determine if a CSM is the Authorization Server is to check the module name for authoriztion-proxy-server, which isAuthorizationProxyServer does.
alikdell
previously approved these changes
Feb 13, 2025
ChristianAtDell
approved these changes
Feb 14, 2025
donatwork
approved these changes
Feb 14, 2025
alexemc
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calculating state, the CSM name is checked to determine if the CSM is the Authorization Proxy Server or not. If the CSM name is not the default name,
authorization, reconciling fails. Determining if the CSM is the Authorization Proxy Server or not should be be hardened by checking if a module name in the spec isauthorization-proxy-server.Changes:
authorization-controllerwhen checking Authorization statusgo mod tidyintests/e2eto make build pass in image scan actionGitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Updated and new unit tests. Installed Authorization using default and non-default names.